feat: email sign up confirmation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, sign up is a transaction with the db. If insert works, and email is sent, it is commited. If it works but mail does not, it is rolled back.
TODO: add database_url to circle ci env variables
Thus, removing sqlx prepared queries.
TODO: refactor functions TODO: make html returns TODO: resend email (and refresh token and expiry)
Closed
it has same return for success and failure, to avoid user enumeration useful link: https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign up is now a db transaction.
Email is only sent if the insert to the db would work.
But insert is only committed if the email is sent correctly.
Bug: I think the mail provider is changing the href url. I'm not comfy with that, because they might be wanting to track my users.
Closes #23