Skip to content

Commit

Permalink
Tag v2.4.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Nicolas Beauvais committed Apr 9, 2019
1 parent e17ef5f commit 588d818
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 21 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
<a name="2.4.3"></a>
# [2.4.3](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.2...2.4.3) (2019-04-09)
- Fix IE11 popup.window bug

<a name="2.4.2"></a>
# [2.4.2](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.1...2.4.2) (2019-02-21)
- Fix build
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vue-social-sharing",
"version": "2.4.2",
"version": "2.4.3",
"homepage": "https://github.com/nicolasbeauvais/vue-social-sharing",
"authors": [
"nicolasbeauvais <nicolasbeauvais1@gmail.com>"
Expand Down
17 changes: 9 additions & 8 deletions dist/vue-social-sharing.common.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* vue-social-sharing v2.4.2
* vue-social-sharing v2.4.3
* (c) 2019 nicolasbeauvais
* Released under the MIT License.
*/
Expand Down Expand Up @@ -285,16 +285,17 @@ var SocialSharing = {
var this$1 = this;

// If a popup window already exist it will be replaced, trigger a close event.
if (this.popup.window && this.popup.interval) {
var popupWindow = null;
if (popupWindow && this.popup.interval) {
clearInterval(this.popup.interval);

this.popup.window.close();// Force close (for Facebook)
popupWindow.close();// Force close (for Facebook)

this.$root.$emit('social_shares_change', network, this.url);
this.$emit('change', network, this.url);
}

this.popup.window = window.open(
popupWindow = window.open(
url,
'sharer',
'status=' + (this.popup.status ? 'yes' : 'no') +
Expand All @@ -312,14 +313,14 @@ var SocialSharing = {
',directories=' + (this.popup.directories ? 'yes' : 'no')
);

this.popup.window.focus();
popupWindow.focus();

// Create an interval to detect popup closing event
this.popup.interval = setInterval(function () {
if (this$1.popup.window.closed) {
if (popupWindow.closed) {
clearInterval(this$1.popup.interval);

this$1.popup.window = undefined;
popupWindow = undefined;

this$1.$root.$emit('social_shares_close', network, this$1.url);
this$1.$emit('close', network, this$1.url);
Expand Down Expand Up @@ -365,7 +366,7 @@ var SocialSharing = {
}
};

SocialSharing.version = '2.4.2';
SocialSharing.version = '2.4.3';

SocialSharing.install = function (Vue) {
Vue.component('social-sharing', SocialSharing);
Expand Down
17 changes: 9 additions & 8 deletions dist/vue-social-sharing.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* vue-social-sharing v2.4.2
* vue-social-sharing v2.4.3
* (c) 2019 nicolasbeauvais
* Released under the MIT License.
*/
Expand Down Expand Up @@ -287,16 +287,17 @@ var SocialSharing = {
var this$1 = this;

// If a popup window already exist it will be replaced, trigger a close event.
if (this.popup.window && this.popup.interval) {
var popupWindow = null;
if (popupWindow && this.popup.interval) {
clearInterval(this.popup.interval);

this.popup.window.close();// Force close (for Facebook)
popupWindow.close();// Force close (for Facebook)

this.$root.$emit('social_shares_change', network, this.url);
this.$emit('change', network, this.url);
}

this.popup.window = window.open(
popupWindow = window.open(
url,
'sharer',
'status=' + (this.popup.status ? 'yes' : 'no') +
Expand All @@ -314,14 +315,14 @@ var SocialSharing = {
',directories=' + (this.popup.directories ? 'yes' : 'no')
);

this.popup.window.focus();
popupWindow.focus();

// Create an interval to detect popup closing event
this.popup.interval = setInterval(function () {
if (this$1.popup.window.closed) {
if (popupWindow.closed) {
clearInterval(this$1.popup.interval);

this$1.popup.window = undefined;
popupWindow = undefined;

this$1.$root.$emit('social_shares_close', network, this$1.url);
this$1.$emit('close', network, this$1.url);
Expand Down Expand Up @@ -367,7 +368,7 @@ var SocialSharing = {
}
};

SocialSharing.version = '2.4.2';
SocialSharing.version = '2.4.3';

SocialSharing.install = function (Vue) {
Vue.component('social-sharing', SocialSharing);
Expand Down
4 changes: 2 additions & 2 deletions dist/vue-social-sharing.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vue-social-sharing",
"description": "A Vue.js component for sharing links to social networks",
"version": "2.4.2",
"version": "2.4.3",
"author": {
"name": "nicolasbeauvais",
"email": "nicolasbeauvais1@gmail.com"
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import SocialSharing from './social-sharing';

SocialSharing.version = '2.4.2';
SocialSharing.version = '2.4.3';

SocialSharing.install = (Vue) => {
Vue.component('social-sharing', SocialSharing);
Expand Down

0 comments on commit 588d818

Please sign in to comment.