Fix #143 + release v2.4.6

nicolasbeauvais · Aug 11, 2019 · a2af057 · a2af057
1 parent e8efffe
commit a2af057
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+<a name="2.4.6"></a>
+# [2.4.6](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.5...2.4.6) (2019-08-11)
+- Fix IOS Twitter sharing with empty hashtags, again
+
 <a name="2.4.5"></a>
 # [2.4.5](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.4...2.4.5) (2019-05-31)
 - Fix IOS Twitter sharing with empty hashtags

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "vue-social-sharing",
-  "version": "2.4.5",
+  "version": "2.4.6",
   "homepage": "https://github.com/nicolasbeauvais/vue-social-sharing",
   "authors": [
     "nicolasbeauvais <nicolasbeauvais1@gmail.com>"

diff --git a/dist/vue-social-sharing.common.js b/dist/vue-social-sharing.common.js
@@ -1,5 +1,5 @@
 /*!
- * vue-social-sharing v2.4.5 
+ * vue-social-sharing v2.4.6 
  * (c) 2019 nicolasbeauvais
  * Released under the MIT License.
  */
@@ -249,7 +249,7 @@ var SocialSharing = {
        * Source: https://github.com/nicolasbeauvais/vue-social-sharing/issues/143
         */
       if (network === 'twitter' && this.hashtags.length === 0) {
-        url.replace('&hashtags=@hashtags', '');
+        url = url.replace('&hashtags=@hashtags', '');
       }
 
       return url
@@ -389,7 +389,7 @@ var SocialSharing = {
   }
 };
 
-SocialSharing.version = '2.4.5';
+SocialSharing.version = '2.4.6';
 
 SocialSharing.install = function (Vue) {
   Vue.component('social-sharing', SocialSharing);

diff --git a/dist/vue-social-sharing.js b/dist/vue-social-sharing.js
@@ -1,5 +1,5 @@
 /*!
- * vue-social-sharing v2.4.5 
+ * vue-social-sharing v2.4.6 
  * (c) 2019 nicolasbeauvais
  * Released under the MIT License.
  */
@@ -251,7 +251,7 @@ var SocialSharing = {
        * Source: https://github.com/nicolasbeauvais/vue-social-sharing/issues/143
         */
       if (network === 'twitter' && this.hashtags.length === 0) {
-        url.replace('&hashtags=@hashtags', '');
+        url = url.replace('&hashtags=@hashtags', '');
       }
 
       return url
@@ -391,7 +391,7 @@ var SocialSharing = {
   }
 };
 
-SocialSharing.version = '2.4.5';
+SocialSharing.version = '2.4.6';
 
 SocialSharing.install = function (Vue) {
   Vue.component('social-sharing', SocialSharing);

diff --git a/dist/vue-social-sharing.min.js b/dist/vue-social-sharing.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "vue-social-sharing",
   "description": "A Vue.js component for sharing links to social networks",
-  "version": "2.4.5",
+  "version": "2.4.6",
   "author": {
     "name": "nicolasbeauvais",
     "email": "nicolasbeauvais1@gmail.com"

diff --git a/src/index.js b/src/index.js
@@ -1,6 +1,6 @@
 import SocialSharing from './social-sharing';
 
-SocialSharing.version = '2.4.5';
+SocialSharing.version = '2.4.6';
 
 SocialSharing.install = (Vue) => {
   Vue.component('social-sharing', SocialSharing);