Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharing by sms with iOs and iMessage #133

Closed
tpin85 opened this issue Apr 11, 2019 · 8 comments
Closed

sharing by sms with iOs and iMessage #133

tpin85 opened this issue Apr 11, 2019 · 8 comments

Comments

@tpin85
Copy link

tpin85 commented Apr 11, 2019

Hi,
Sharing by sms is in trouble on iOs and iMessage. Work fine on android. The 'description' param is push into the recipients phones numbers.
You can see in screenshot the issue in iMessage.

Capture d’écran 2019-04-11 à 10 59 53

Thanks

@nicolasbeauvais
Copy link
Owner

Hello @tpin85,

It appears that IOS use a non-standard parsing for the SMS body (more info here).

This should now work with the latest version 2.4.4.

Thank you for reporting the error.

@MaeseppTarvo
Copy link

@nicolasbeauvais Tested on 2.4.6 and still an issue.

@marshallino16
Copy link

Tested on 2.4.7 and still an issue

@nicolasbeauvais
Copy link
Owner

Hello @MaeseppTarvo and @marshallino16, I do not own any IOS device to debug this issue, please feel free to open a PR with a fix if you can.

@holygekko
Copy link

it should use an & instead of ;

"sms_ios": {
    "sharer": "sms:&body=@url%20@description",
    "type": "direct"
  }

see this SO answer: https://stackoverflow.com/questions/39529099/trying-to-send-sms-in-ios-10-is-sms-protocol-broken/39572784#39572784

I temporally fixed it by overwriting the sms_ios sharer via the networks property (https://github.com/nicolasbeauvais/vue-social-sharing#extending-the-network-list)

@VictorVermeulen
Copy link

it should use an & instead of ;

"sms_ios": {
    "sharer": "sms:&body=@url%20@description",
    "type": "direct"
  }

see this SO answer: https://stackoverflow.com/questions/39529099/trying-to-send-sms-in-ios-10-is-sms-protocol-broken/39572784#39572784

I temporally fixed it by overwriting the sms_ios sharer via the networks property (https://github.com/nicolasbeauvais/vue-social-sharing#extending-the-network-list)

Does this mean you needed to update to version 3.x as that github link suggests? I tried overwriting the sms_ios sharer with version 2.4.7 and I think that doesn't work. However I am not sure I can update to version 3.x since I am not using SSR or Vue 3.x

@nicolasbeauvais
Copy link
Owner

@holygekko thank you for the code sample, the latest version as been updated with your suggested change!

@nicolasbeauvais
Copy link
Owner

@VictorVermeulen Indeed it was not very clear in the documentation, I updated it. The v3 of Vue Social Sharing is fully compatible with Vue2 and non-SSR projects. But I will keep it in beta until Vue3 is released in case something need to be changed to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants