Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge popup UI update #48

Merged
merged 26 commits into from Oct 19, 2018
Merged

Merge popup UI update #48

merged 26 commits into from Oct 19, 2018

Conversation

nicolaschan
Copy link
Owner

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #48 into master will decrease coverage by 0.22%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   90.17%   89.95%   -0.23%     
==========================================
  Files          29       29              
  Lines         621      627       +6     
  Branches       85       87       +2     
==========================================
+ Hits          560      564       +4     
- Misses         34       35       +1     
- Partials       27       28       +1
Impacted Files Coverage Δ
src/BellTimer.js 83.33% <0%> (-0.18%) ⬇️
src/themes/Jonathan.js 100% <100%> (ø) ⬆️
src/themes/Halloween.js 100% <100%> (ø) ⬆️
src/ThemeManager.ts 92.5% <60%> (-4.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74b9f5...7286538. Read the comment docs.

Copy link
Collaborator

@noloerino noloerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this so I'm pretty ok with it

@nicolaschan nicolaschan self-assigned this Oct 19, 2018
@nicolaschan nicolaschan merged commit 43194a5 into master Oct 19, 2018
@noloerino
Copy link
Collaborator

noloerino commented Oct 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants