Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic types in parameters #20

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

glennvgastel
Copy link
Collaborator

This PR will add support for generic types in type parameters.
I've added the relevant test and modified the readme to reflect the new feature.

@nicolasdao
Copy link
Owner

Fantastic @Calcyfer .

I'm in holidays ATM and I'm back on the 8th in Sydney. I'll do my best to review that before. Worst case scenario, I'll review it on the 8th.

Thanks a lot for your work.

Cheers,

Nic

@iamdanthedev
Copy link

Hello guys
Any luck with this PR?
Seems to be a killer feature
Thanks

@glennvgastel
Copy link
Collaborator Author

@iamdanthedev Not yet, as the maintainer hasn't had time to check them yet, but I'm using a combination of the 2 currently open PRs in a project right now.

Feel free to fork that branch.

@iamdanthedev
Copy link

@Calcyfer thanks for the link!

@nicolasdao nicolasdao merged commit 1ba4aed into nicolasdao:master Aug 14, 2018
@nicolasdao
Copy link
Owner

Great work @Calcyfer.

I've just reviewed your PR and everything was fine. I've merged it and released a new version on npm (0.17.0). I'm looking for collaborators, so if you're interested, let me know so I can add you as a contributor to this project.

Thanks again.

Nic

@glennvgastel
Copy link
Collaborator Author

Thanks @nicolasdao.

I'd be happy to contribute, so feel free to add me and I'll track the project and update when and where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants