New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include tests in pecl archive, fix test with redis < 2.6.9, fix build warnings #333
Conversation
@@ -1651,6 +1651,9 @@ public function testPersist() { | |||
} | |||
|
|||
public function testClient() { | |||
if (version_compare($this->version, "2.6.9", "lt")) { | |||
$this->markTestSkipped(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of this test?
Oh right, just saw your follow-up. Thanks. |
This is the last. All build warnign fix. Please be carefull on 5757df4 |
Note, about is_numeric, I think it could be usefull to add a condition on strlen(value)<MAX_LENGTH_OF_LONG |
Well that's not the best example :-)
"1234567890123456789" is indeed parsed as a number here. "12345678901234567891234567890123456789" shouldn't be, though. Detecting the threshold purely on the number of characters might be too restrictive. I'll think about what we can do in this case... |
@remicollet Thanks for the pull request. At a quick glance, I think you are correct regarding 5757df4. I'll take a closer look but nice find! :) |
deprecated |
fixes issue #322