Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include tests in pecl archive, fix test with redis < 2.6.9, fix build warnings #333

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions package.xml
Expand Up @@ -53,6 +53,13 @@ http://pear.php.net/dtd/package-2.0.xsd">
<file role='src' name='redis.c'/>
<file role='src' name='redis_session.c'/>
<file role='src' name='redis_session.h'/>
<dir name="tests">
<file name="array-tests.php" role="test" />
<file name="memory.php" role="test" />
<file name="mkring.sh" role="test" />
<file name="test.php" role="test" />
<file name="TestRedis.php" role="test" />
</dir> <!-- //tests -->
</dir> <!-- / -->
</contents>
<dependencies>
Expand Down
3 changes: 3 additions & 0 deletions tests/TestRedis.php
Expand Up @@ -1651,6 +1651,9 @@ public function testPersist() {
}

public function testClient() {
if (version_compare($this->version, "2.6.9", "lt")) {
$this->markTestSkipped();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this test?

}
/* CLIENT SETNAME */
$this->assertTrue($this->redis->client('setname', 'phpredis_unit_tests'));

Expand Down