Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBSCRIBE closes connection, does not keep-alive? #32

Closed
okko opened this issue Sep 2, 2011 · 4 comments
Closed

SUBSCRIBE closes connection, does not keep-alive? #32

okko opened this issue Sep 2, 2011 · 4 comments

Comments

@okko
Copy link

okko commented Sep 2, 2011

I'm unable to subscribe to a channel through HTTP. It appears the connection gets closed as soon as the subscription is done, and that HTTP headers (ie. content-type) are completely missing from the response. Should it work?

$ tests/pubsub -r 10 -w 10 -n 10
# kept it running, can see in the Redis log the SUBSCRIBE commands and the PUBLISH commands
Received 0 messages from 10 writers to 10 readers through 1 channels in 273.75 sec: received 0.00 msg/sec
$ telnet localhost 7379
GET /SUBSCRIBE/chan HTTP/1.1

24
{"SUBSCRIBE":["subscribe","chan",1]}
Connection closed by foreign host.
@nicolasff
Copy link
Owner

Fixed! This was a regression and is indeed not supposed to happen.

@okko
Copy link
Author

okko commented Sep 5, 2011

Now the connection stays properly open and data is transferred, thanks, but the HTTP headers are still missing. For example,

Content-Type: application/json
Date: Mon, 03 Jan 2011 20:43:36 GMT
Transfer-Encoding: chunked
(and the empty line)

@nicolasff
Copy link
Owner

You are right, sorry about that; most of the issues with pub/sub are regressions from a previous change and it seems that there were still problems with pub/sub.

Please try the latest master, I have just pushed a fix and confirmed that headers are sent properly.

@okko
Copy link
Author

okko commented Sep 6, 2011

Thank you again, now it works beautifully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants