Improve support for newer msgpack-c releases. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0.5.8, msgpack-c has provided a pkg-config file. If it's installed, use pkg-config to get the relevant CFLAGS/LDFLAGS. Signed-off-by: James McCoy <jamessan@jamessan.com>
In msgpack-c's 1.0.0 release, the code was changed to be compatible with the v5 msgpack spec, specifically separating out the STR and BIN types as replacements for the old RAW type. While the STR type is likely the right replacement type to use, it does introduce a str 8 variant that wasn't present for the old RAW type. For better compatibility, the msgpack_pack_v4raw functions were added to directly map to the old functionality. Signed-off-by: James McCoy <jamessan@jamessan.com>
The msgpack library may be present in /usr/lib or /usr/lib/$arch, but only the former is being searched. Check both places and fix the library name to use the C lib (libmsgpackc) rather than the C++ lib (libmsgpack). Signed-off-by: James McCoy <jamessan@jamessan.com>
|
Updated to also look for libmsgpackc in multi-arch library paths for msgpack-c releases which don't yet have pkg-config support (even though those are quite old). |
|
Ping? |
|
@nicolasff do you plan to accept this PR? It provides support for modern versions of the library and makes external patching unnecessary. FYI: Webdis exists in Debian archive with these patches for two years already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which had to make incompatible changes to accomodate changes
in the msgpack spec itself.