fix for bindings order when using where clause

[n1crack]

The bindings order were wrong. The following code includes published scope which is $query->where('published_at', '<=', Carbon::now()); ..

$articles = Article::with('category')->published()->search($request->get('q'))->paginate(10);

params are:
0 2016-12-10 10:56:21
1 2016-12-10 10:56:21
2 test
3 test%
4 %test%
5 test
6 test%
7 %test%

which is wrong.
Correct Params should have been with this order :

0	test
1	test%
2	%test%
3	test
4	test%
5	%test%
6	2016-12-10 10:56:21
7	2016-12-10 10:56:21

My sql was like : (date and query params were at wrong places.)
select count() as aggregate from (select articles., max((case when LOWER(articles.title) LIKE '2016-12-10 10:56:21'' then 300 else 0 end) ..... bla bla bla.... having relevance > 7.50 order by relevance desc) as articles where published_at <= '%test%'

So made the changes. That fixed my issue for me . I am not sure if it breaks anything. So someone else should test it.

I am using laravel 5.3

have a good day.

[nicolaslopezj]

Nice! Can someone confirm this is working for everyone?

[diszad]

@nicolaslopezj This works for me.

[Ghaji]

am trying to use the nicolaslopezj searchableTraits on Laravel 5.2.45 but getting this error "Call to undefined method Illuminate\Database\Query\Builder::search()" below is my controller can someone help

public function searchResult(Request $request){

	try {
        $v = validator()->make($request->all(), [
                'formsearch'       => 'required|min:3|max:50',
          ]);

        if( $v->fails() ) {

            return redirect()->back()->withInput()->withErrors($v);

        } else {

        	$users = User::search($request->get('formsearch'))->get();

        	return view('searchResult.search', compact('users'));
            
        }
    } catch(Exception $e) {
        return redirect()->back()->withMessage("An error occurred ".$e->getMessage());
    }