Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeutralAnnotator -- Rename to annotator, as neutral prefix is related to a specifics of the particular task #122

Closed
nicolay-r opened this issue May 27, 2021 · 0 comments
Closed

NeutralAnnotator -- Rename to annotator, as neutral prefix is related to a specifics of the particular task #122

nicolay-r opened this issue May 27, 2021 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request
Projects
arekit-project-0.21.0

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 27, 2021 •
edited
Loading

Here are the examples:
BaseNeutralAnnotator -> BaseAnnotator
DefaultNeutralAlgorithm -> SingleLabelAnnotationAlgorithm

Everything due to the generalization.
@nicolay-r nicolay-r added enhancement New feature or request critical labels May 27, 2021
@nicolay-r nicolay-r self-assigned this May 27, 2021
@nicolay-r nicolay-r mentioned this issue May 27, 2021
Closed
@nicolay-r nicolay-r added this to 0.21.0 in arekit-project-0.21.0 May 27, 2021
@nicolay-r nicolay-r changed the title NeutralAnnotator -- Rename to annotator, as neutral is a specific of the particular task NeutralAnnotator -- Rename to annotator, as neutral prefix is related to a specifics of the particular task May 27, 2021
nicolay-r added a commit that referenced this issue May 27, 2021
@nicolay-r
Refactoring related to #93 which also lead to #122
0f23b3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request
Projects
No open projects
arekit-project-0.21.0
  
done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r