Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repositiories -- add this class which unite all the providers for data writing #195

Closed
nicolay-r opened this issue Sep 18, 2021 · 0 comments
Closed

Repositiories -- add this class which unite all the providers for data writing #195

nicolay-r opened this issue Sep 18, 2021 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request
Projects
arekit-project-0.22.0

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Sep 18, 2021 •
edited
Loading

Proceeds #194

Problem: such providers suppose to be initialized sequently, but:

  1. ColumnProvider -- requires text_columns
  2. RowsProvider -- requires text_provider, which inlucdes text_columns

Solution: it might be easier to setup such parameters at Repository class.
@nicolay-r nicolay-r added enhancement New feature or request critical labels Sep 18, 2021
@nicolay-r nicolay-r self-assigned this Sep 18, 2021
nicolay-r added a commit that referenced this issue Sep 19, 2021
@nicolay-r
Refactoring: #195
92a4084
nicolay-r added a commit that referenced this issue Dec 27, 2021
@nicolay-r
Fixed bug: couple times utitilized iter (doc_ids_iter) works only once (
150535c 
#195 related)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request
Projects
No open projects
arekit-project-0.22.0
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r