Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__get_opinion_end_indices -- might return incorrect Entity indices #336

Closed
nicolay-r opened this issue Jun 16, 2022 · 0 comments
Closed

__get_opinion_end_indices -- might return incorrect Entity indices #336

nicolay-r opened this issue Jun 16, 2022 · 0 comments
Assignees
@nicolay-r
Labels
bug Something isn't working question Further information is requested

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jun 16, 2022 •
edited
Loading

In some cases, indices might refer to string entries rather than entity entries (instances):

AREkit/arekit/common/data/input/providers/rows/samples.py

Lines 195 to 201 in d754221

s_ind = service.get_entity_position(text_opinion.SourceId).get_index(
position_type=TermPositionTypes.IndexInSentence)
t_ind = service.get_entity_position(text_opinion.TargetId).get_index(
position_type=TermPositionTypes.IndexInSentence)
return s_ind, t_ind

@nicolay-r nicolay-r added the bug Something isn't working label Jun 16, 2022
@nicolay-r nicolay-r self-assigned this Jun 16, 2022
@nicolay-r nicolay-r added the question Further information is requested label Jun 16, 2022
@nicolay-r nicolay-r changed the title __get_opinion_end_indices -- might return incorrect Entity indices __get_opinion_end_indices -- might return incorrect Entity indices Jun 16, 2022
@nicolay-r nicolay-r mentioned this issue Jun 17, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r