Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine -- provide states iterator as a parameter instead of DataFolding #341

Closed
nicolay-r opened this issue Jun 18, 2022 · 0 comments
Closed

Engine -- provide states iterator as a parameter instead of DataFolding #341

nicolay-r opened this issue Jun 18, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request task
Projects
arekit-project-0.22.1

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jun 18, 2022 •
edited
Loading

We may generalize this, as not all the experiments should be based on DataFolding:

AREkit/arekit/common/experiment/engine.py

Lines 46 to 47 in 877b8e2

for iter_index, _ in enumerate(self.__data_folding.iter_states()):
self._handle_iteration(iter_index)

@nicolay-r nicolay-r added the enhancement New feature or request label Jun 18, 2022
@nicolay-r nicolay-r self-assigned this Jun 18, 2022
@nicolay-r nicolay-r changed the title Engine -- provide states iterator as a parameter instead of DataFolding Engine -- provide states iterator as a parameter instead of DataFolding Jun 18, 2022
@nicolay-r nicolay-r added the task label Jun 18, 2022
nicolay-r added a commit that referenced this issue Jun 19, 2022
@nicolay-r
#341 done.
3d702cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request task
Projects
No open projects
arekit-project-0.22.1
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r