Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide JSON writer for OpenNRE library #378

Closed
1 task done
nicolay-r opened this issue Jul 27, 2022 · 0 comments
Closed
1 task done

Provide JSON writer for OpenNRE library #378

nicolay-r opened this issue Jul 27, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request task
Projects
arekit-project-0.22.1

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 27, 2022 •
edited
Loading

The default writer is a TSV-based which means that we keep everything in CSV.

  • embed it into the AREkit

AREkit/arekit/contrib/utils/model_io/tf_networks.py

Lines 58 to 59 in 8d78e56

def create_samples_writer(self):
return TsvWriter(write_header=True)

AREkit/arekit/contrib/utils/model_io/bert.py

Lines 87 to 88 in 8d78e56

def create_samples_writer(self):
return TsvWriter(write_header=True)

However we can provide the one for JSON, for https://github.com/thunlp/OpenNRE
@nicolay-r nicolay-r added the task label Jul 27, 2022
@nicolay-r nicolay-r self-assigned this Jul 27, 2022
@nicolay-r nicolay-r changed the title Provide Writer for OpenNRE library Provide JSON writer for OpenNRE library Jul 27, 2022
@nicolay-r nicolay-r added the enhancement New feature or request label Jul 27, 2022
nicolay-r added a commit that referenced this issue Jul 29, 2022
@nicolay-r
#378 allows modify extension
8abc84b
nicolay-r added a commit that referenced this issue Sep 1, 2022
@nicolay-r
#378 done
4f428e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request task
Projects
No open projects
arekit-project-0.22.1
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r