Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameVariant -- Lowercased frame variants #403

Closed
nicolay-r opened this issue Sep 16, 2022 · 0 comments
Closed

FrameVariant -- Lowercased frame variants #403

nicolay-r opened this issue Sep 16, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request limitation question Further information is requested

Comments

@nicolay-r
Copy link
Owner

Question: is it quite important to perform lowercasing?
Suppose this has been a part of the implementation related to a particular collection like RuAttitudes.

def __init__(self, text, frame_id):
assert(isinstance(text, str))
assert(isinstance(frame_id, str))
self.__terms = text.lower().split()

@nicolay-r nicolay-r added enhancement New feature or request question Further information is requested limitation labels Sep 16, 2022
@nicolay-r nicolay-r self-assigned this Sep 16, 2022
nicolay-r added a commit that referenced this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limitation question Further information is requested
Projects
No open projects
arekit-project-0.23.0
Awaiting triage
Development

No branches or pull requests

1 participant