Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googletrans -- TranslatorPipelineItem for parsed texts #416

Closed
nicolay-r opened this issue Nov 25, 2022 · 2 comments
Closed

googletrans -- TranslatorPipelineItem for parsed texts #416

nicolay-r opened this issue Nov 25, 2022 · 2 comments
Assignees
@nicolay-r
Labels
task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Nov 25, 2022 •
edited
Loading

Consider the following cases also:

 translator.translate(['                 \r\n'], src="ru", dest="en")

raises an exception of 'NoneType' object is not iterable
@nicolay-r nicolay-r added the task label Nov 25, 2022
@nicolay-r nicolay-r self-assigned this Nov 25, 2022
@nicolay-r nicolay-r mentioned this issue Nov 25, 2022
Closed
nicolay-r added a commit that referenced this issue Nov 25, 2022
@nicolay-r
#416 and #418
cbc5efd
@nicolay-r
Copy link
Owner Author

nicolay-r commented Nov 25, 2022 •
edited
Loading

Done, but then expected to be moved into a separated repository

@nicolay-r
Copy link
Owner Author

Fail, in case of a couple entities appearance in a row

nicolay-r added a commit that referenced this issue Nov 25, 2022
@nicolay-r
#416 refactoring, fixed missed cases of the original implementation
0b3e187
nicolay-r added a commit that referenced this issue Nov 25, 2022
@nicolay-r
#416 fix
de81638
@nicolay-r nicolay-r changed the title TranslatorPipelineItem for parsed texts googletrans --TranslatorPipelineItem for parsed texts Nov 25, 2022
@nicolay-r nicolay-r changed the title googletrans --TranslatorPipelineItem for parsed texts googletrans -- TranslatorPipelineItem for parsed texts Nov 25, 2022
nicolay-r added a commit that referenced this issue Nov 25, 2022
@nicolay-r
#418 switched to display_value. #416 related. Now we don't modify the…
5420b74 
… oriainal value, since it affects on the `SynonymsCollection` behavior.
nicolay-r added a commit that referenced this issue Nov 27, 2022
@nicolay-r
#416 clarified and #418 related
db6579b
@nicolay-r nicolay-r mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r