Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support None for get_doc_existed_opinion_func [user/paper feedback] #469

Closed
nicolay-r opened this issue May 13, 2023 · 1 comment
Closed

Support None for get_doc_existed_opinion_func [user/paper feedback] #469

nicolay-r opened this issue May 13, 2023 · 1 comment
Assignees
@nicolay-r
Labels
critical enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 13, 2023 •
edited
Loading

Reason: for the snippet below, it would be so handy to avoid get_doc_existed_opinions_func / consider None by default, in the case when there is no such preliminary annotation.

AlgorithmBasedTextOpinionAnnotator(
    PairBasedOpinionAnnotationAlgorithm(
     dist_in_terms_bound=50,
     label_provider=
      ConstantLabelProvider(NoLabel())),
    value_to_group_id_func=
     lambda v: stemmer.lemmatize_to_str(v))
    get_doc_existed_opinions_func=
     lambda _: OpinionCollection(synonyms),
    create_empty_collection_func=
     lambda: OpinionCollection(synonyms))
   ],

AREkit/arekit/common/opinions/annot/algo_based.py

Line 16 in 3583f38

def __init__(self, annot_algo, create_empty_collection_func, get_doc_existed_opinions_func):

@nicolay-r nicolay-r added enhancement New feature or request task critical labels May 13, 2023
@nicolay-r nicolay-r self-assigned this May 13, 2023
@nicolay-r nicolay-r changed the title Support None for get_doc_existed_opinion_func Support None for get_doc_existed_opinion_func [user/paper feedback] May 13, 2023
@nicolay-r
Copy link
Owner Author

It actually supports the following parameter setup:

AREkit/arekit/contrib/utils/pipelines/sources/rusentrel/extract_text_opinions.py

Line 76 in d8c691c

get_doc_existed_opinions_func=lambda _: None,

AREkit/arekit/contrib/utils/pipelines/sources/rusentrel/extract_text_opinions.py

Line 89 in d8c691c

get_doc_existed_opinions_func=lambda _: None,

@nicolay-r nicolay-r reopened this May 15, 2023
nicolay-r added a commit that referenced this issue May 16, 2023
@nicolay-r
#443 update, fixed bugs. #469 proof of already considered support.
65bf617
nicolay-r added a commit that referenced this issue May 17, 2023
@nicolay-r
#469 supported.
700456d
nicolay-r added a commit that referenced this issue May 17, 2023
@nicolay-r
#469 fixed incorrect initialization of function
7ebdffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r