Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortening to RuSentRelOpinions.iter_from_doc #480

Closed
nicolay-r opened this issue May 23, 2023 · 0 comments
Closed

Shortening to RuSentRelOpinions.iter_from_doc #480

nicolay-r opened this issue May 23, 2023 · 0 comments

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented May 23, 2023 •
edited
Loading

Reason: provider only returns opinions, non wrapped into collection. Also, since we know that result is related to Opinions, there is no need to additionally mention it in method name

AREkit/arekit/contrib/source/rusentrel/opinions/collection.py

Line 13 in c048884

def iter_opinions_from_doc(doc_id, labels_fmt, version=RuSentRelVersions.V11):

@nicolay-r nicolay-r changed the title Shortening to iter_from_docs Shortening to RuSentRelOpinions.iter_from_doc May 23, 2023
nicolay-r added a commit that referenced this issue May 25, 2023
@nicolay-r
#480 refactored
4204ea7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r