SamplesIO target extension -- make extention a part of the writer [annoying, user experience feedback]

[nicolay-r]

Problem: switching from one format to the other becomes necessary when the writer has changed.
So output format is supposed to be associated with the writer.

• Removed target_extension custom parameter (d33aa51)
• Samples instanciates everywhere with writer. We may consider that user should specify at least one provider.

AREkit/tests/tutorials/test_tutorial_pipeline_sampling_network.py

Line 95 in a624ae1

samples_io=SamplesIO(self.__output_dir, writer, target_extension=".tsv.gz"),

• make this code a part of the related classes:
  

  AREkit/arekit/contrib/utils/data/ext.py

  Lines 13 to 23 in a624ae1

  	def create_writer_extension(writer):
  	assert(isinstance(writer, BaseWriter))
  	if isinstance(writer, OpenNREJsonWriter):
  	return OPENNRE_EXTENSION
  	if isinstance(writer, PandasCsvWriter):
  	return PANDAS_CSV_EXTENSION
  	if isinstance(writer, NativeCsvWriter):
  	return ".csv"
  	raise NotImplementedError()

AREkit/arekit/contrib/utils/data/ext.py

Lines 26 to 34 in a624ae1

	def create_reader_extension(writer):
	assert(isinstance(writer, BaseReader))
	if isinstance(writer, PandasCsvReader):
	return PANDAS_CSV_EXTENSION
	if isinstance(writer, OpenNREJsonWriter):
	return OPENNRE_EXTENSION
	raise NotImplementedError()