This repository has been archived by the owner on May 23, 2019. It is now read-only.
Rewrote parser to a more flexible version. Fixes #14 and #15 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser is not longer based on the shunting yard algorithm as it was not flexible enough. The new version is based on a grammar and therefore can be extended by any feature that can be expressed in the grammar. This commit also fixes issues 14 and 15.
This was referenced Aug 22, 2015
|
Cool. I'm happy for the switch to a recursive descent parser... mainly b/c I'm more familiar with them which will make it easier for me to help out. |
| }); | ||
|
|
||
| it("should consecutive expressions as multiplication", function(){ | ||
| var input = "(x + 2) * (x + 2)"; |
There was a problem hiding this comment.
Shouldn't this test case be (x + 2)(x + 2)?
There was a problem hiding this comment.
You are right, thanks. I fixed it.
|
Does it handle |
|
It does handle 5(x+2) and (x+2)5. I added tests for that. |
|
Awesome, thank you! |
|
Nice! I'll pull this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser is not longer based on the shunting yard algorithm as it was not flexible enough. The new version is based on a grammar and therefore can be extended by any feature that can be expressed in the grammar.
With the grammar it should be easy to include parsing future features.
This commit also fixes issues 14 and 15.