Reduce recursion when disposing sync resources

nicolo-ribaudo · Jun 16, 2023 · 9d41888 · 9d41888
1 parent 5f74b51
commit 9d41888
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 19 deletions.
diff --git a/packages/babel-helpers/src/helpers-generated.ts b/packages/babel-helpers/src/helpers-generated.ts
@@ -63,7 +63,7 @@ export default Object.freeze({
   ),
   dispose: helper(
     "7.22.0",
-    'function dispose_SuppressedError(suppressed,error){return"undefined"!=typeof SuppressedError?dispose_SuppressedError=SuppressedError:(dispose_SuppressedError=function(suppressed,error){this.suppressed=suppressed,this.error=error,this.stack=(new Error).stack},dispose_SuppressedError.prototype=Object.create(Error.prototype,{constructor:{value:dispose_SuppressedError,writable:!0,configurable:!0}})),new dispose_SuppressedError(suppressed,error)}export default function _dispose(stack,error,hasError){function next(){if(0!==stack.length){var r=stack.pop();if(r.a)return Promise.resolve(r.d.call(r.v)).then(next,err);try{r.d.call(r.v)}catch(e){return err(e)}return next()}if(hasError)throw error}function err(e){return error=hasError?new dispose_SuppressedError(e,error):e,hasError=!0,next()}return next()}',
+    'function dispose_SuppressedError(suppressed,error){return"undefined"!=typeof SuppressedError?dispose_SuppressedError=SuppressedError:(dispose_SuppressedError=function(suppressed,error){this.suppressed=suppressed,this.error=error,this.stack=(new Error).stack},dispose_SuppressedError.prototype=Object.create(Error.prototype,{constructor:{value:dispose_SuppressedError,writable:!0,configurable:!0}})),new dispose_SuppressedError(suppressed,error)}export default function _dispose(stack,error,hasError){function next(){for(;stack.length>0;){var r=stack.pop();if(r.a)return Promise.resolve(r.d.call(r.v)).then(next,err);try{r.d.call(r.v)}catch(e){return err(e)}}if(hasError)throw error}function err(e){return error=hasError?new dispose_SuppressedError(e,error):e,hasError=!0,next()}return next()}',
   ),
   iterableToArrayLimit: helper(
     "7.0.0-beta.0",

diff --git a/packages/babel-helpers/src/helpers/dispose.js b/packages/babel-helpers/src/helpers/dispose.js
@@ -22,21 +22,18 @@ function dispose_SuppressedError(suppressed, error) {
 
 export default function _dispose(stack, error, hasError) {
   function next() {
-    if (stack.length === 0) {
-      if (hasError) throw error;
-      return;
+    while (stack.length > 0) {
+      var r = stack.pop();
+      if (r.a) {
+        return Promise.resolve(r.d.call(r.v)).then(next, err);
+      }
+      try {
+        r.d.call(r.v);
+      } catch (e) {
+        return err(e);
+      }
     }
-
-    var r = stack.pop();
-    if (r.a) {
-      return Promise.resolve(r.d.call(r.v)).then(next, err);
-    }
-    try {
-      r.d.call(r.v);
-    } catch (e) {
-      return err(e);
-    }
-    return next();
+    if (hasError) throw error;
   }
 
   function err(e) {

diff --git a/packages/babel-runtime-corejs3/helpers/dispose.js b/packages/babel-runtime-corejs3/helpers/dispose.js
@@ -14,15 +14,14 @@ function dispose_SuppressedError(suppressed, error) {
 }
 function _dispose(stack, error, hasError) {
   function next() {
-    if (0 !== stack.length) {
+    for (; stack.length > 0;) {
       var r = stack.pop();
       if (r.a) return _Promise.resolve(r.d.call(r.v)).then(next, err);
       try {
         r.d.call(r.v);
       } catch (e) {
         return err(e);
       }
-      return next();
     }
     if (hasError) throw error;
   }

diff --git a/packages/babel-runtime/helpers/dispose.js b/packages/babel-runtime/helpers/dispose.js
@@ -11,15 +11,14 @@ function dispose_SuppressedError(suppressed, error) {
 }
 function _dispose(stack, error, hasError) {
   function next() {
-    if (0 !== stack.length) {
+    for (; stack.length > 0;) {
       var r = stack.pop();
       if (r.a) return Promise.resolve(r.d.call(r.v)).then(next, err);
       try {
         r.d.call(r.v);
       } catch (e) {
         return err(e);
       }
-      return next();
     }
     if (hasError) throw error;
   }