Support Node.js v12 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
12 is eol later this week fwiw |
|
I know... We even support Node.js 10 in main branch. 😄 |
|
I proposed to drop Node.js 10 last year, it's still open 😄 . prettier/prettier#10157, we'll decide before we ship V3. |
|
Jest 28 will be released today. Dropping 10, but keeping 12 😀 |
|
Lucky for us. |
|
FYI: Node.js v4 EOL 2018-04-30, we drop support 2020-03-21 https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes |
|
We also needs Node.js 12 support for Babel tests! I wanted to fix this today, so thanks for the PR! (And Babel still supports Node.js 6, using Jest 25 😩) |
nicolo-ribaudo
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier still support Node.js 12 :(