Changed default Firebase return value to undefined (#361)

boardgameio · Feb 12, 2019 · 87d1e5b · 87d1e5b
1 parent 83f0c74
commit 87d1e5b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/server/db/firebase.js b/src/server/db/firebase.js
@@ -124,6 +124,10 @@ export class Firebase {
       this.cache.set(id, doc);
     }
 
+    if (doc === null) {
+      return undefined;
+    }
+
     return doc;
   }
 

diff --git a/src/server/db/firebase.test.js b/src/server/db/firebase.test.js
@@ -58,7 +58,7 @@ describe('Firestore', async () => {
 
   test('must return undefined when no game exists', async () => {
     const state = await db.get('gameID');
-    expect(state).toEqual(null);
+    expect(state).toEqual(undefined);
   });
 
   test('cache hit', async () => {
@@ -158,7 +158,7 @@ describe('RTDB', async () => {
 
   test('must return undefined when no game exists', async () => {
     const state = await db.get('gameID');
-    expect(state).toEqual(null);
+    expect(state).toEqual(undefined);
   });
 
   test('cache hit', async () => {