disable move if playerID is null

boardgameio · May 1, 2018 · ca9f6ca · ca9f6ca
1 parent 9c8ecb9
commit ca9f6ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/core/flow.js b/src/core/flow.js
@@ -23,7 +23,7 @@ function canPlayerMakeMove(G, ctx, opts) {
   // In multiplayer mode, the default playerID is null, which corresponds
   // to a spectator that can't make moves.
   if (playerID === null) {
-    return true;
+    return false;
   }
 
   // In singleplayer mode (and most unit tests), the default playerID

diff --git a/src/core/flow.test.js b/src/core/flow.test.js
@@ -467,6 +467,11 @@ test('canMakeMove', () => {
   state = reducer(state, makeMove('C'));
   expect(state.G).toMatchObject({ C: true });
 
+  // But not if the playerID is null (spectator).
+  state.G = {};
+  state = reducer(state, makeMove('A', null, null));
+  expect(state.G).not.toMatchObject({ A: true });
+
   // But not once the game is over.
   state.ctx.gameover = true;
   state.G = {};