-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support move limits in setActivePlayers
#452
Merged
nicolodavis
merged 18 commits into
boardgameio:master
from
delucis:delucis/active-players-move-limit
Sep 15, 2019
Merged
feat: Support move limits in setActivePlayers
#452
nicolodavis
merged 18 commits into
boardgameio:master
from
delucis:delucis/active-players-move-limit
Sep 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables passing a `moveLimit` option to `setActivePlayers` similar in API to `setActivePlayers` itself
setActivePlayers
@nicolodavis Let me know if you think anything needs changing here. I think it's ready to merge, but you might have better ideas for variable naming or more efficient implementations. |
Will take a look soon. A bit busy this weekend, so probably sometime on Monday. Thanks for the great work! |
nicolodavis
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work towards #445
Support
moveLimit
option insetActivePlayers
, storing result inctx._activePlayersMoveLimit
Track moves by currently active players in
ctx._activePlayersNumMoves
Reset player counts whenever
setActivePlayers
is called and when the turn endsEnd stages when player has reached move limit
Remove
once
option in favour ofmoveLimit
Restore previous move limits and counts when using
revert: true