Fix favicon finding properly

Now falls back to website-level finding in a more sensible way
nicolus · Jan 22, 2020 · d7fb537 · d7fb537
1 parent dd433fd
commit d7fb537
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/PicoFeed/Reader/Favicon.php b/lib/PicoFeed/Reader/Favicon.php
@@ -156,15 +156,17 @@ public function find($website_link, $favicon_link = '')
 
                 if ($this->content !== '') {
                     return $icon_link;
-                } elseif ($favicon_link !== '') {
-                    return $this->find($website_link);
                 }
             } catch (RequestException $e) {
                 continue;
             }
         }
 
-        return '';
+        if ($favicon_link !== '') {
+            return $this->find($website_link);
+        } else {
+            return '';
+        }
     }
 
     /**