Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined offset notice #14

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Fix undefined offset notice #14

merged 1 commit into from
Jun 5, 2019

Conversation

fl0pp
Copy link
Contributor

@fl0pp fl0pp commented Jun 4, 2019

This change fixes error message:

PHP Notice:  Undefined offset: 0 in vendor/nicolus/picofeed/lib/PicoFeed/Client/Client.php on line 685

@coveralls
Copy link

Pull Request Test Coverage Report for Build 49

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 95.156%
Files with Coverage Reduction New Missed Lines %
lib/PicoFeed/Client/Client.php 2 86.96%
Totals Coverage Status
Change from base Build 47: -0.1%
Covered Lines: 1768
Relevant Lines: 1858
💛 - Coveralls

@nicolus nicolus merged commit 4b7afd4 into nicolus:master Jun 5, 2019
@nicolus
Copy link
Owner

nicolus commented Jun 5, 2019

Nice catch, thanks you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fl0pp @coveralls @nicolus