Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On GrapheneOS AMR files are not supported and detected #81

Closed
Mattrazol opened this issue Feb 22, 2024 · 5 comments
Closed

On GrapheneOS AMR files are not supported and detected #81

Mattrazol opened this issue Feb 22, 2024 · 5 comments

Comments

@Mattrazol
Copy link

Describe the bug
If on GrapheneOS in the voice recording I select AMR-WB as the "Audio output format" the files that are generated by the recording (files .amr) are not recognized by the app (even if they correctly match the regex) and therefore they are not displayed on the list of recordings (Home).

To Reproduce
Steps to reproduce the behavior:

  1. Open the app
  2. Select a folder containing recordings from GraoheneOS that are in .amr format
  3. The home screen doesn't detect any of them

Expected behavior
The files should be displayed and be able to be reproduced just like AAC or other audio format file

Versions (please complete the following information):

  • BCR-GUI version: 1.5.0
  • Device: Google Pixel 7
  • Android version: 14
@Mattrazol Mattrazol changed the title On GrapheneOS's AMR files are not supported and detected On GrapheneOS AMR files are not supported and detected Feb 22, 2024
@nicorac
Copy link
Owner

nicorac commented Feb 22, 2024

BCR-GUI does not filter files by extension but on MIME type (returned by Android SAF - Storage Access Framework).

These are the MIME types currently supported:

public readonly supportedTypes: string[] = [

.amr MIME type should be something like audio/amr.
Could you confirm it? (you could see it with a filemanager, details...)
Otherwise I could try to create one .amr file on my side...

@Mattrazol
Copy link
Author

I've tried to look for the mime-type with a few file manager but I couldn't figure it out. But by looking online it seems like you might be right the mime type should be "audio/AMR" I would double check though because I didn't invest too much time into it

@nicorac
Copy link
Owner

nicorac commented Feb 22, 2024

Here's a build that adds support for audio/amr MIME type files.

bcr-gui-1.5.0-release-with-amr-support.apk.zip

Please confirm that it both shows (after a refresh) and plays AMR files correctly.

NOTE: it has the same 1.5.0 version of the latest official version...

@Mattrazol
Copy link
Author

Yes it works perfectly!
Thank you so much!

@nicorac
Copy link
Owner

nicorac commented Feb 22, 2024

Great, thanks for your feedback.
Will merge the change to dev branch, so you'll find it in next release.
Feel free to use this build since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants