Skip to content

Commit

Permalink
Censor List: fix incorrect function call
Browse files Browse the repository at this point in the history 
Noted in #924
  • Loading branch information
@mathiascode
mathiascode committed Jan 2, 2021
1 parent 9a09f3c commit 631255d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pynicotine/gtkgui/settingswindow.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ def __init__(self, parent):
def cell_edited_callback(self, widget, index, value, treeview, pos):

store = treeview.get_model()
iterator = store.get_iterator(index)
iterator = store.get_iter(index)

if value != "" and not value.isspace() and len(value) > 2:
store.set(iterator, pos, value)
Expand Down
4 changes: 2 additions & 2 deletions pynicotine/gtkgui/ui/settings/events.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Run command after download finishes ($ for filename):</property>
<property name="label" translatable="yes">Run command after download finishes ($ for folder path):</property>

This comment has been minimized.

Sign in to view

Copy link
@redactedscribe

redactedscribe Jan 4, 2021

Contributor

Perhaps the underlying code is indeed substituting $ as the single download's folder path (hence your correction), but does it not make more sense to provide the single download's file path instead? But maybe this was just a quick fix to at least be accurate regarding the code.

Also, this string, and the other may need a little more clarification, because I'm assuming "after download finishes" means a single file download (due to the context of the other options), but this could be misinterpreted as any type of download finishing: file or folder. If it does indeed mean a run command for individual file downloads, then too, does this command get ignored when a user chooses to download several files as a folder? I.e. this command won't be executed for each file in the folder download, only the command below (run command once folders finish) will execute.

This comment has been minimized.

Sign in to view

Copy link
@mathiascode

mathiascode Jan 4, 2021

Author Member

Looks like I changed these a bit too quickly without verifying the context.This is indeed a file path.
</object>
<packing>
<property name="expand">False</property>
Expand Down Expand Up @@ -114,7 +114,7 @@
<object class="GtkLabel">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="label" translatable="yes">Audio Player Command ($ for filename):</property>
<property name="label" translatable="yes">Audio Player Command ($ for folder path):</property>
<property name="xalign">0</property>
</object>
<packing>
Expand Down

0 comments on commit 631255d

Please sign in to comment.