Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: No more charsets selection ? #180

Closed
zniavre opened this issue May 24, 2020 · 3 comments
Closed

Question: No more charsets selection ? #180

zniavre opened this issue May 24, 2020 · 3 comments

Comments

@zniavre
Copy link
Contributor

zniavre commented May 24, 2020

One of a thing nicotine was unique ...

Thank you for every improvement you ve done !!!
@eLvErDe
Copy link
Collaborator

eLvErDe commented May 24, 2020

If I remember correctly the old soulseek server was running ISO8859-1 and they switch to UTF-8 at some point.
So this charset stuff is probably remaining cruft from old times, can be safely dropped IMHO.

@mathiascode
Copy link
Member

I removed it in #171, to simplify the whole encoding/decoding process. UTF-8 should work for everything nowadays.

@mathiascode
Copy link
Member

Can we close this? Doesn't seem like any issues have popped up since.

@zniavre zniavre closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eLvErDe @zniavre @mathiascode