Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatView: use explicit username in append_line() #2792

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

slook
Copy link
Member

@slook slook commented Dec 18, 2023

  • Added: Clickable roomname tags to close Public chat room feed: Don't notify on new messages + clickable room names #2482
  • Changed: Prepend chat logs into ChatView widgets upon tab activation rather than during application launch
  • Fixed: Part of the timestamp was incorrectly tagged if the username is a short numeric that's also in timestamp
  • Fixed: New room wall message was appended at the end instead of being prepended to start upon text entry
  • Avoids the use of find() when inserting text for online chat messages, it is only needed when reading old log file lines
  • Reduces counting the number of characters while inserting text unless doing so is really necessary
  • Reverts msg.formatted_message as it is not part of the protocol, this direct tag approach doesn't require it anyway.

The idea of tagging lines in batches is for a more efficient on-demand log file readback mechanism. Not only is application startup time much improved, but there is also scope for reading back old messages from the log file on demand, even after new chat message lines have already been appended.

Reference draft PR #2540

@slook slook force-pushed the chatview-append-line-message-text branch from 830e488 to 8b3eaed Compare December 18, 2023 01:20
@slook slook changed the title Chat View: use explicit username in append_line() ChatView: use explicit username in append_line() Dec 18, 2023
@slook slook force-pushed the chatview-append-line-message-text branch from 8b3eaed to ec8df96 Compare December 18, 2023 01:38
@slook slook marked this pull request as draft December 18, 2023 01:38
@slook slook force-pushed the chatview-append-line-message-text branch from ec8df96 to 5731c70 Compare December 18, 2023 19:57
@mathiascode mathiascode added this to the 3.4.0 milestone May 16, 2024
@slook slook force-pushed the chatview-append-line-message-text branch 17 times, most recently from 7e566f7 to 660b5d9 Compare June 24, 2024 10:39
@slook slook force-pushed the chatview-append-line-message-text branch from 660b5d9 to 157ff17 Compare June 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Public chat room feed: Don't notify on new messages + clickable room names
2 participants