ChatView: use explicit username in append_line() #2792
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roomname
tags to close Public chat room feed: Don't notify on new messages + clickable room names #2482find()
when inserting text for online chat messages, it is only needed when reading old log file linesmsg.formatted_message
as it is not part of the protocol, this direct tag approach doesn't require it anyway.The idea of tagging lines in batches is for a more efficient on-demand log file readback mechanism. Not only is application startup time much improved, but there is also scope for reading back old messages from the log file on demand, even after new chat message lines have already been appended.
Reference draft PR #2540