Missing default translation string setting for updater.errors

[akoepcke]

Describe the bug
When having German as OS language setting, the translation strings for the updater.error modal are incomplete. The text does not fall back to default English, but displays the string names instead.

To Reproduce
Steps to reproduce the behavior:

1. Switch Mac OS system language settings to German (I'm guessing any other non-english language works as well).
2. Kill WLAN/network connection
3. Klick "Check for updates..."

Expected behavior
When the modal appears that tells me it can't check for updates, I expect the modal to have a clearly understandable error message. Since the whole app is in english, I expect that error message to be in plain English as well.

Screenshots

Required information

• Did you consult the FAQ in the README? not applicable
• Did you try "Fix My Valet"? not applicable
• OS: macOS Monterey, including all system updates until August 14th, 2022
• OS region setting: Germany
• OS language setting: German(primary), English
• PHP Monitor Version 5.4.1 (912)

[nicoverbruggen]

Thanks for reporting, I will definitely look at this and ensure this is fixed in the next release! Do any other strings appear untranslated or is this the only one you noticed?

Edit: Ah, I changed the keys, so this message is broken on any system configuration. Whoops!

[akoepcke]

Ah, nice. That was an easy fix then 😁
And no, I did not encounter any other strings. The rest is English as expected 👍🏻