Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated value in Domains list window #261

Closed
1 task done
simo-l2k opened this issue Sep 7, 2023 · 4 comments
Closed
1 task done

Duplicated value in Domains list window #261

simo-l2k opened this issue Sep 7, 2023 · 4 comments
Assignees
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!

Comments

@simo-l2k
Copy link

simo-l2k commented Sep 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The domain list window show a single entry for each site, except one that is showing two times.
Screenshot 2023-09-07 alle 16 58 12

Expected Behavior

The domain list window should list an entry for each site

Steps To Reproduce

  1. Open PHP Monitor from menu bar
  2. Click View Domains List
  3. Only one site is duplicated (valet-dashboard)

Environment

- macOS: Ventura 13.4.1
- Valet: 3.3.2
- PHP Monitor: 6.0.1

Do you have a log file (or a screenshot) or any additional information?

last_session.log

@simo-l2k simo-l2k added the bug Something isn't working (correctly). label Sep 7, 2023
@nicoverbruggen
Copy link
Owner

Interesting issue, I've never encountered this before. Any chance there is an additional alias or symlink in your ~/Sites folder @simo-l2k?

If you're unsure, can you run ls -la ~/Sites and let me know what's in there (assuming nothing confidential)?

Anyway, thanks for reporting!

Duplicates really shouldn't show up (at least if both the domain and the path are identical; there may be reasons you want the same path to be used for multiple domains) so I'll get this fixed, just in time for the next update later this week. 😁

@simo-l2k
Copy link
Author

simo-l2k commented Sep 7, 2023

I agree with you: it's an interesting issue. 😁
There are no symlink: the output of ls is the following:

ls -la ~/Sites
total 24
drwxr-xr-x 15 simone staff 480 7 Set 16:30 .
drwx------+ 123 simone staff 3936 7 Set 18:04 ..
-rw-r--r--@ 1 simone staff 10244 7 Set 16:31 .DS_Store
drwxr-xr-x 8 simone staff 256 11 Feb 2022 Contabilita
drwxr-xr-x 9 simone staff 288 9 Ago 10:38 Contabilita2
drwxr-xr-x 12 simone staff 384 5 Ott 2020 Domain Configurator
drwxrwxr-x 29 simone staff 928 28 Feb 2022 FamilyBalance
drwxr-xr-x 9 simone staff 288 14 Ott 2020 OVH Configurator
drwxr-xr-x 108 simone staff 3456 29 Set 2022 Trovalavoro
drwxr-xr-x 28 simone staff 896 7 Set 15:10 aliens
drwxr-xr-x 29 simone staff 928 14 Apr 18:04 aliens_epp
drwxrwxr-x 29 simone staff 928 9 Mar 2022 axs
drwxr-xr-x 30 simone staff 960 2 Mar 2022 domdash
drwxr-xr-x 7 simone staff 224 18 Mag 11:51 epp
drwxrwxr-x@ 20 simone staff 640 7 Set 16:04 valet-dashboard

The only difference between the duplicate entry and the others is that it is a "control" dashboard:
https://github.com/frankyonnetti/valet-dashboard

Setted the dashboard as the default page in .config/valet/config.json as reccomended.

All is working perfectly: the duplicate entry is only a small annoiance.

@nicoverbruggen
Copy link
Owner

Ah, if it's your default then that's why this is happening! Thanks for letting me know. Should not be too hard to fix in that case.

@nicoverbruggen nicoverbruggen added the fixed in upcoming release Fixed in the upcoming release! label Sep 7, 2023
@simo-l2k
Copy link
Author

Installed 6.1: i can confirm duplicated value disappeared. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Development

No branches or pull requests

2 participants