Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Won't launch due to Valet: allow launch if Valet exists in ~/.composer #27

Closed
nicoverbruggen opened this issue Mar 31, 2021 · 1 comment
Closed

Won't launch due to Valet: allow launch if Valet exists in ~/.composer #27

nicoverbruggen opened this issue Mar 31, 2021 · 1 comment
Assignees
@nicoverbruggen
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!
Milestone
v3.3

Comments

@nicoverbruggen
Copy link
Owner

nicoverbruggen commented Mar 31, 2021 •
edited

As reported in #23, some folks still seem to have issues getting the app to launch (the pre-flight checks fail).

During the launch checks, I should also look for Valet in ~/.composer/vendor/bin/valet.

A workaround for users is currently:

ln -s ~/.composer/vendor/bin/valet /usr/local/bin/valet

This will satisfy PHP Monitor's check in /usr/local/bin/valet.
@nicoverbruggen nicoverbruggen added the bug Something isn't working (correctly). label Mar 31, 2021
@nicoverbruggen nicoverbruggen self-assigned this Mar 31, 2021
nicoverbruggen added a commit that referenced this issue Mar 31, 2021
@nicoverbruggen
🐛 Be more lenient about Valet checks (#27)
f750063
@nicoverbruggen nicoverbruggen added the fixed in upcoming release Fixed in the upcoming release! label Mar 31, 2021
@nicoverbruggen nicoverbruggen changed the title Allow launch if Valet exists in ~/.composer/vendor/bin/valet PHP Monitor complains about Valet: allow launch if Valet exists in ~/.composer/vendor/bin/valet Mar 31, 2021
@nicoverbruggen nicoverbruggen changed the title PHP Monitor complains about Valet: allow launch if Valet exists in ~/.composer/vendor/bin/valet Won't launch due to Valet: allow launch if Valet exists in ~/.composer Mar 31, 2021
@nicoverbruggen
Copy link
Owner Author

nicoverbruggen commented Mar 31, 2021 •
edited

This should be fixed in v3.3 (pre-release 3).
It would be helpful if you could try out this build and let me know if the issue has been resolved.

You can give it a try here: https://github.com/nicoverbruggen/phpmon/releases/download/v3.3-prerelease3/phpmon.zip

@nicoverbruggen nicoverbruggen added this to the v3.3 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicoverbruggen nicoverbruggen

Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Milestone
v3.3
Development

No branches or pull requests
1 participant
@nicoverbruggen