Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling extensions doesn't restart php-fpm (so the change doesn't take effect) #32

Closed
atymic opened this issue Apr 1, 2021 · 3 comments
Assignees
Labels
fixed in upcoming release Fixed in the upcoming release!
Milestone

Comments

@atymic
Copy link

atymic commented Apr 1, 2021

Hey, awesome app!

I'm not sure if this is a local issue, but when I toggle an extension (say xdebug) it doesn't trigger a fpm restart, so i need to head back into the menu and trigger that restart manually. Is it possible to get this to happen automatically?

Thanks :)

@nicoverbruggen nicoverbruggen self-assigned this Apr 1, 2021
@nicoverbruggen nicoverbruggen added the enhancement New feature or request. label Apr 1, 2021
@nicoverbruggen
Copy link
Owner

Right now, this is very much by design, but I think it would be nice to have php-fpm restart if you want that to happen.

I'll add it as a preference in v4.0!

@nicoverbruggen
Copy link
Owner

I've added this to preferences for the upcoming version (4.0), and this will be turned on by default, since the overhead of restarting PHP-FPM seems to be minimal:

image

Thanks for reporting!

@nicoverbruggen nicoverbruggen added fixed in upcoming release Fixed in the upcoming release! and removed enhancement New feature or request. labels Nov 13, 2021
@nicoverbruggen
Copy link
Owner

Available now in PHP Monitor 4.0!
More here: https://github.com/nicoverbruggen/phpmon/releases/tag/v4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Development

No branches or pull requests

2 participants