Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable does not work for symlinked .ini files #47

Closed
nicoverbruggen opened this issue Jun 8, 2021 · 2 comments
Closed

Disable does not work for symlinked .ini files #47

nicoverbruggen opened this issue Jun 8, 2021 · 2 comments
Assignees
@nicoverbruggen
Labels
fixed in upcoming release Fixed in the upcoming release!
Milestone
v4.0

Comments

@nicoverbruggen
Copy link
Owner

See title.
@nicoverbruggen nicoverbruggen added the bug Something isn't working (correctly). label Jun 8, 2021
@nicoverbruggen nicoverbruggen self-assigned this Jun 8, 2021
@nicoverbruggen nicoverbruggen mentioned this issue Jun 8, 2021
Closed
@nicoverbruggen
Copy link
Owner Author

The easiest solution for this will be to check if gsed is installed / exists, and if it does, prefer that over sed. I'll add gnu-sed as a dependency in the Homebrew cask, in which case it should be fine for most users.

nicoverbruggen added a commit that referenced this issue Nov 13, 2021
@nicoverbruggen
✨ Use gsed so we can follow symlinks to .ini files (#39, #47)
34900f9
@nicoverbruggen nicoverbruggen added fixed in upcoming release Fixed in the upcoming release! and removed bug Something isn't working (correctly). labels Nov 13, 2021
@nicoverbruggen nicoverbruggen added this to the v4.0 milestone Nov 13, 2021
@nicoverbruggen
Copy link
Owner Author

Available now in PHP Monitor 4.0!
More here: https://github.com/nicoverbruggen/phpmon/releases/tag/v4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicoverbruggen nicoverbruggen

Labels
fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@nicoverbruggen