Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

subscriber: update screenshots consistently #72

Open
nictuku opened this issue Apr 13, 2016 · 1 comment
Open

subscriber: update screenshots consistently #72

nictuku opened this issue Apr 13, 2016 · 1 comment

Comments

@nictuku
Copy link
Owner

nictuku commented Apr 13, 2016

The subscriber currently creates the screenshot after the savegame. We use the savegame availability to find the screenshots - so when people hit the homepage, they may see a reference to a screenshot that hasn't been generated yet.

We should probably invert the order of generating the screenshot vs writing the save game to the db.
@nictuku
Copy link
Owner Author

nictuku commented Apr 13, 2016

missing

demonstrating the issue

nictuku added a commit that referenced this issue Apr 14, 2016
@nictuku
Write the screenshot first, optionally. Should help with issue #72
5c4903a
nictuku added a commit that referenced this issue Apr 14, 2016
@nictuku
Revert "Write the screenshot first, optionally. Should help with issue …
e1659e8 
…#72"

This reverts commit 5c4903a.

It made screenshots and savegames be saved with different timestamps. Lesson learned: stop testing stuff in prod, even if you're tired and lazy :-(.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nictuku