Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs need different path to images #41

Closed
evelynmitchell opened this issue Oct 9, 2020 · 1 comment · Fixed by #58
Closed

Docs need different path to images #41

evelynmitchell opened this issue Oct 9, 2020 · 1 comment · Fixed by #58
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@evelynmitchell
Copy link
Contributor

https://igel.readthedocs.io/en/latest/_sources/readme.rst.txt includes a link to the assets/igel-help.gif, but that path is broken on readthedocs.

readme.rst is included as ../readme.rst in the sphinx build.
The gifs are in asses/igel-help.gif

The sphinx build needs to point to the asset directory, absolutely:

.. image:: /assets/igel-help.gif

I haven't made a patch, because I haven't tested this.

@nidhaloff
Copy link
Owner

@evelynmitchell Thanks for opening this. Yes you are right I checked it now, I don't have much time these days that's why I didn't notice this. I will try to check it out when I have more time. Feel free to work on solving this if you would like to, or maybe someone else can investigate this meanwhile.

@nidhaloff nidhaloff pinned this issue Oct 14, 2020
@nidhaloff nidhaloff added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Oct 14, 2020
florianbussmann added a commit to florianbussmann/igel that referenced this issue May 26, 2021
@nidhaloff nidhaloff unpinned this issue May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants