Fix edge case in nondet detection for PSO #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initial event from the backtrack set was a branch (control flow), the nondeterminism detection from ac12d1a would mistakenly assume that it must go the same way (true/false) as the next branch in the previous execution of the program, which might be by a different thread entirely. This can cause spurious nondeterminism error reports. Already fixed for SC&TSO in 702d438. Does not affect POWER/ARM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial event from the backtrack set was a branch (control flow),
the nondeterminism detection from ac12d1a would mistakenly assume that
it must go the same way (true/false) as the next branch in the previous
execution of the program, which might be by a different thread entirely.
This can cause spurious nondeterminism error reports.
Already fixed for SC&TSO in 702d438. Does not affect POWER/ARM.
Test will be added by a separate pull request, due to it triggering multiple bugs.