Skip to content

Commit

Permalink
GYP: Escape filenames with space in generate-embed actions
Browse files Browse the repository at this point in the history
Filenames with space are not supported, but correctly escaping them
trigger a nice error from GYP instead of cryptic error message.
  • Loading branch information
efyx committed Jul 19, 2017
1 parent 3ee29f8 commit f700f9a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions gyp/actions.gyp
Expand Up @@ -13,9 +13,9 @@
# Any change to dir2nvfs will trigger the action
'<(nidium_src_path)/Tools/dir2nvfs.cpp',
'<(nidium_tools_path)dir2nvfs',
# If I use find command inside a variable, output is not
# considered as multiple files using it in inputs works fine
'<!@(find <(nidium_embed_dir) -type f)',
# Using find command inside a variable, output is not
# considered as multiple files. Using it in inputs works fine
'<!@(find <(nidium_embed_dir) -type f |sed \'s/.*/"&"/\')',
],
'outputs': [
'<(nidium_embed_bin)'
Expand Down

0 comments on commit f700f9a

Please sign in to comment.