Do not inform if the substring does not exist

nielsbasjes · Aug 28, 2017 · 007aa3f · 007aa3f
1 parent e61cbec
commit 007aa3f
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/analyzer/src/main/java/nl/basjes/parse/useragent/parse/UserAgentTreeFlattener.java b/analyzer/src/main/java/nl/basjes/parse/useragent/parse/UserAgentTreeFlattener.java
@@ -407,11 +407,17 @@ private void informSubstrings(ParserRuleContext ctx, String name, boolean fakeCh
         if (ranges.size() > 4) { // Benchmarks showed this to be the breakeven point. (see below)
             List<Pair<Integer, Integer>> splitList = splitter.createSplitList(text);
             for (Range range : ranges) {
-                inform(ctx, ctx, name + "[" + range.getFirst() + "-" + range.getLast() + "]", splitter.getSplitRange(text, splitList, range), true);
+                String value = splitter.getSplitRange(text, splitList, range);
+                if (value != null) {
+                    inform(ctx, ctx, name + "[" + range.getFirst() + "-" + range.getLast() + "]", value, true);
+                }
             }
         } else {
             for (Range range : ranges) {
-                inform(ctx, ctx, name + "[" + range.getFirst() + "-" + range.getLast() + "]", splitter.getSplitRange(text, range), true);
+                String value = splitter.getSplitRange(text, range);
+                if (value != null) {
+                    inform(ctx, ctx, name + "[" + range.getFirst() + "-" + range.getLast() + "]", value, true);
+                }
             }
         }
     }