Detect DeviceBrand with Chrome 70 on Android

nielsbasjes · Nov 10, 2018 · f4c81e4 · f4c81e4
1 parent 74f32d6
commit f4c81e4
Show file tree

Hide file tree

Showing 6 changed files with 6,833 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,8 @@ This is intended as an overview of the major changes
 v5.4
 ===
 - Detect more Iron variations
+- Major change in the Android Chrome 70 pattern --> broke DeviceBrand
+- Detect Vivo brand
 
 v5.3
 ===

diff --git a/analyzer/src/main/code-gen/UserAgents/MobileBrands/Generate.sh b/analyzer/src/main/code-gen/UserAgents/MobileBrands/Generate.sh
@@ -71,6 +71,15 @@ do
     prefix=$(echo "${line}" | cut -d'|' -f1)
     brand=$(echo "${line}" | cut -d'|' -f2)
 echo "
+# Chrome 70+ on Android no longer has the BUILD/... part
+- matcher:
+    require:
+    - 'agent.(1)product.(1)comments.(1)entry.text=\"Linux\"'
+    - 'agent.(1)product.(1)comments.(2)entry.(1)product.name=\"Android\"'
+    extract:
+    - 'DeviceBrand                         :    323 :\"${brand}\"'
+    - 'DeviceName                          :    323 :agent.(1)product.(1)comments.(3)entry{\"${prefix}\"'
+
 - matcher:
     variable:
     - 'BuildProduct: agent.(1-2)product.(1)comments.entry.product.name=\"Build\"'

diff --git a/analyzer/src/main/code-gen/UserAgents/MobileBrands/MobileBrands.csv b/analyzer/src/main/code-gen/UserAgents/MobileBrands/MobileBrands.csv
@@ -63,6 +63,7 @@ Avea|Avea
 Avvio|Avvio
 Azumi|Azumi
 Lenovo|Lenovo
+Vivo|Vivo
 
 Nexus|Google
 # Pixel is special because some browsers use this term when it is NOT a Pixel device.