fix(connect-user): Use StubCreator to mock firebase during tests

By using StubCreator, the connect-user module can properly import the FirebaseClient. Importing
using require does not work once compiled. This fixes a 500 error on Firebase where the
firebaseClient module could not be found in connectUser

src/eventhandlers/connect-user.ts

@@ -1,10 +1,10 @@
 import Config from "../objects/config"
 import User from "../objects/user"
+import FirebaseClient from "../clients/firebase-client"
 
 export default async (req: any): Promise<string> => {
   const request = require("request-promise")
   const functions = require("firebase-functions")
-  const FirebaseClient = require("../clients/firebase-client")
   const firebaseConfig =
     (global as any).peppermintFirebaseConfig || functions.config()
 

test/eventhandlers/connect-user.test.ts

@@ -1,4 +1,5 @@
 import Peppermint from "../../src/peppermint"
+import StubCreator from "../helpers/stub-creator"
 import { assert } from "chai"
 
 describe("Peppermint.connectUser", () => {
@@ -8,30 +9,11 @@ describe("Peppermint.connectUser", () => {
         post: jest.fn().mockReturnValue({ access_token: "" })
       }
     })
-    jest.mock("firebase-functions", () => {
-      return {
-        config: () => {
-          return {
-            dropbox: {
-              client_id: "XXX",
-              client_secret: "XXX"
-            },
-            oauth: {
-              redirect_after_connect: "https://google.com"
-            }
-          }
-        }
-      }
-    })
-    jest.mock("../../src/clients/firebase-client", () => {
-      return {
-        getInstance: jest.fn().mockReturnValue({
-          addUser: jest.fn()
-        })
-      }
-    })
+    StubCreator.stubFirebase()
   })
 
+  afterEach(StubCreator.restoreFirebase)
+
   it("should exchange an authCode for an access token", async () => {
     let authUrl = await Peppermint.connectUser({
       query: { code: "FAKE_AUTH_CODE" }

test/helpers/stub-creator.ts

@@ -30,7 +30,9 @@ export default class StubCreator {
         // Fake urls, because Firebase complains if we leave them undefined
         databaseURL: "https://mock-firebase.firebaseio.com",
         storageBucket: "mock-firebase.appspot.com"
-      }
+      },
+      dropbox: {},
+      oauth: {}
     })
 
     // Create stub firebase database and enable autoflushing