Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select multiple posts from firebase at once? #38

Closed
nielsmaerten opened this issue Oct 16, 2017 · 1 comment
Closed

Select multiple posts from firebase at once? #38

nielsmaerten opened this issue Oct 16, 2017 · 1 comment
Labels
enhancement investigate performance

Comments

@nielsmaerten
Copy link
Owner

peppermint/src/eventhandlers/on-trigger-reddit-update.ts

Line 17 in 645ab97

if (!await firebase.getPost(topPosts[i])) {

Instead of fetching every post separately, can I select multiple posts at once, and do only 1 call?
To be investigated...
nielsmaerten added a commit that referenced this issue Oct 16, 2017
@nielsmaerten
docs(triggerRedditUpdate): Link Github issue #38
eeb861c
@nielsmaerten
Copy link
Owner Author

Issue #31 overrules this one. Fixing #31 will fix this issue as well.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement investigate performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nielsmaerten