New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cloud api support #12
Conversation
Hi 👋! |
@drc38 Great that this worked out. Actually I did not think much about the consequences of adding cloud API. @drc38 are you using any of the definitions used for the local API? If not, I agree with @farmio that this should go to a separate package. Feel free to just copy the project skeleton, then there should be little to no extra work in separating the packages. |
Originally I had thought the same functions could be repeated eg |
You could always require and import both libraries from the HA integration if you want to ship it in HA Core instead of HACS. There are several integrations already doing this. So you should find working examples in HAs codebase. |
Closing as first draft of cloud api now added to Pypi https://pypi.org/project/fronius-solarweb/ |
To incorporate the cloud api, I have renamed
__init__.py
tolocal.api.py
and imported it in the new__init__.py
file.Looks like the issue with the test files on Windows has meant my repo does not have them, so if you could add them back in that would be great.
Happy to take on board any other feedback.