Skip to content

Commit

Permalink
Update Readme and PR/FR template for language support
Browse files Browse the repository at this point in the history
  • Loading branch information
nielstron committed Sep 22, 2020
1 parent 036f404 commit 4c9d97b
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 16 deletions.
19 changes: 16 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
title: '[BR]'
labels: ''
assignees: ''

Expand All @@ -17,12 +17,25 @@ Steps to reproduce the behavior:
3. Scroll down to '....'
4. See error

**Expected behavior**
**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
**Screenshots**
If applicable, add screenshots to help explain your problem.

**Corresponding printer state**
If applicable, please supply the content of `http://your-printer-ip/sws/app/information/home/home.json`
(accessed via Browser or `wget`)

```json
{
status: {
hrDeviceStatus: 2,
status1: " Sleeping... ",
status2: " ",
...
```

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Python Version: [e.g. 3.5]
Expand Down
15 changes: 14 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
title: '[FR]'
labels: ''
assignees: ''

Expand All @@ -16,5 +16,18 @@ A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Corresponding printer state**
If applicable, please supply the content of `http://your-printer-ip/sws/app/information/home/home.json`
(accessed via Browser or `wget`)

```json
{
status: {
hrDeviceStatus: 2,
status1: " Sleeping... ",
status2: " ",
...
```

**Additional context**
Add any other context or screenshots about the feature request here.
12 changes: 0 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,3 @@ async def main():
loop = asyncio.get_event_loop()
loop.run_until_complete(main())
```

## Troubleshooting

If the general state of your printer stays at 'Unknown',
it might be the case that the language of your printer is not supported.

Even though officially your language is supported it might be that
some states are not exactly matching the expected states stored in the library.
For this case, have a look at the language support issue template for a detailed how-to on adding support for your printer
or open a general issue.

Current supported languages are: English, Russian, German, French, Italian

0 comments on commit 4c9d97b

Please sign in to comment.