Fix tray filtering and reporting #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielstron
force-pushed
the
fix_tray_support
branch
from
5b34ca1
to
4dc9289
Compare
|
@OzGav feel free to have a look at the changes made here. I adjusted the code for the new trays such that optimally little to no change will be visible in the Home Assistant interface. |
Closed
nielstron
added a commit
that referenced
this pull request
Sep 24, 2020
nielstron
added a commit
that referenced
this pull request
Sep 24, 2020
nielstron
added a commit
that referenced
this pull request
Sep 24, 2020
nielstron
added a commit
that referenced
this pull request
Sep 24, 2020
|
Thanks Niels, I am trying to compare the HA code to this code as well. I note the HA code has up to 6 trays. This code only goes up to 5. I don't know which is correct, that is, what is the maximum number of trays that a Samsung printer can support? Besides that it appears ok to me. My Python isn't that great though... The original issue that triggered this is that the HA integration currently reports UNKNOWN for all trays. In the HA code what is this doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues mentioned in #41 and adds more tray types.