Add counter for print & copy #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would fail on non-color devices.
|
Hi @sebcaps, thanks for your addition! Could you please rebase your changes on the latest version of the |
Feat/unescaped newline
Various fixes and improvements to the example
nielstron
reviewed
Nov 14, 2023
|
|
||
| async def _current_data(self) -> Dict[str, Any]: | ||
| async def _current_data(self, datatype: Any) -> Dict[str, Any]: |
There was a problem hiding this comment.
It might make sense to split this function into _current_data_home and _current_data_counter or sth similar
|
This addition will also require additional use cases to be added to cover the counter json. Please also provide raw json output for the counter.json API output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to get number of print & copies for the printer.
No HTML scrapping supported for these data => an exception is raised for these data with HTML scrapping.